animation: Prevent spinner animation from resetting

Currently, the search status spinner animation restarts on every
single keystroke while a search is in progress. This occurs because
redundant calls to `play()` replace the previous content and restart
the animation from the beginning.

This commit fixes this by ignoring redundant `play()` and `stop()` calls.

Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8695

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4191>

diff --git a/js/ui/animation.js b/js/ui/animation.js
index 882241cb1e5678a96c26ccdb583f63f54d1ec475..a76bc3a9adbefa17c6a1d74adb36fc1ab028cf2e 100644 (file)
--- a/js/ui/animation.js
+++ b/js/ui/animation.js
@@ -32,6 +32,8 @@ class Spinner extends St.Widget {
     }
 
     play() {
+        if (this._playing)
+            return;
         this.remove_all_transitions();
         this.set_content(new St.SpinnerContent());
         this.show();
@@ -49,6 +51,8 @@ class Spinner extends St.Widget {
     }
 
     stop() {
+        if (!this._playing)
+            return;
         this.remove_all_transitions();
 
         if (this._animate) {
@@ -70,4 +74,8 @@ class Spinner extends St.Widget {
                 this.hide();
         }
     }
+
+    get _playing() {
+        return this.visible && this.content !== null;
+    }
 });